Sync upstream repo - #2
Merged
Merged
Conversation
Resolves issue #5123 "Charts framework takes a long time to build" (#5123) by implementing the recommendations listed at the end of the issue: - Set `Eager Linking` build setting to `Yes` for `Charts` framework target - Set `Enable Module Verifier` build setting to `No` for `Debug` builds - Set `Compilation Mode` to `Incremental` for `Debug` builds - Add `-Xfrontend -warn-long-expression-type-checking=50` (or perhaps use `100`) to `OTHER_SWIFT_FLAGS` so the Swift compiler will emit warnings for expressions that take a long time to type-check. The number after the = is the number of milliseconds threshold, above which warnings will be emitted. - Refactored the slow type-checking hotspots identified above in `ChartAnimationEasing.swift`, breaking out expressions which are slow to type-check into separate, quicker-to-type-check expressions.
…e methods Resolved log10 and pow errors by explicitly calling Double.log10() and Double.pow(). Fixed type mismatch in division operation (shifted / magnitude). Ensured compatibility with latest Swift compiler requirements. Preparing to apply these fixes to the main library as well.
When updating the data set for the chart and then animating it, sometimes highlights are generated for the
// removed sets. This guard prevents OOB in the case where the new set has less data than the old set
Improved uniform spacing in pie charts
Fix crash in LineChartRenderer.swift when animating data set changes
Fix FloatingPoint functions: Replace instance calls with static Double
Added Safe index subscript logic for ChartData
Charts/issues/5197 - fixed host app crash by adding a check before ca…
Added tests for BarChartView
Posibility to add Corner Radius for rounded bars in bar chart
Make partitioningIndex public
Improves build time by 30%, resolving issue 5123 "Charts Framework takes a long time to build"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Goals ⚽
Implementation Details 🚧
Testing Details 🔍